 Arthur Hulsman
|
6a2ca534d2
|
Removed redundant wrappers within the adsmanager promises.
|
2018-03-09 14:29:37 +01:00 |
|
|
Arthur Hulsman
|
7adc2bc6c8
|
Unneeded else has been removed within the play() method.
|
2018-03-09 13:21:19 +01:00 |
|
|
Arthur Hulsman
|
ba8d7831a7
|
Made sure play() returns a promise.
|
2018-03-09 12:50:57 +01:00 |
|
|
Arthur Hulsman
|
69ffcbad27
|
Ad block detection would not work when calling play() right after creating the player instance, so the adsManager now also rejects on such a case. Also made sure that calling play() will wait for the adsManager promise to resolve or otherwise return the media.play() method.
|
2018-03-09 11:17:24 +01:00 |
|
|
Arthur Hulsman
|
819f7d1080
|
Resizing the ad container while having it on display none will return offset width and height of 0, which will cause ads not to play when ad sizes are set within the clients DSP. Also making sure that the inner containers of the ad container are full size. The container is now hidden/ displayed using z-index.
|
2018-03-07 15:43:48 +01:00 |
|
|
Arthur Hulsman
|
409b588458
|
Made sure that cue points for midrolls are not displayed when the ad rule for a midroll doesn't exceed the total play time of a video.
|
2018-03-07 15:17:30 +01:00 |
|
|
Arthur Hulsman
|
e90a603d57
|
Removed a double this.enabled variable and updated a comment in ads.js. Also made sure the adsmanager promise also can fail, so we can use it to wait for getting the advertisement ready when someone clicks the play button. Otherwise there it can look glitchy when the actual video starts playing and the video ad plays a few seconds later because the vast tag was slow to retrieve. Also fixed a typo.
|
2018-03-06 17:27:59 +01:00 |
|
|
Arthur Hulsman
|
ed6048034b
|
Noticed that Plyr stopped working when ads are blocked.
|
2018-01-18 14:04:47 +01:00 |
|
|
Arthur Hulsman
|
8af312fe3c
|
Updated pause and resume content methods within Ads class.
|
2018-01-18 12:31:10 +01:00 |
|
|
Arthur Hulsman
|
d87ada4f58
|
Reformatted ads codebase and added/ changed comments. Also removed un-used events.
|
2018-01-18 12:26:53 +01:00 |
|
|
Arthur Hulsman
|
31c8166562
|
Fixed string literal and position issue of the midroll cue inside the time line. Added a check for the progress element existence.
|
2018-01-17 15:57:10 +01:00 |
|
|
Arthur Hulsman
|
0cb2f95888
|
Removed an un-used variable.
|
2018-01-17 15:43:08 +01:00 |
|
|
Arthur Hulsman
|
896ea7c689
|
Added cue markings within the time line for when midrolls will be displayed. Removed unusued callback parameter.
|
2018-01-17 15:38:26 +01:00 |
|
|
Arthur Hulsman
|
1d1eb02bd7
|
Added the logging of our main promises to their resolving callback. Otherwise they come up as null.
|
2018-01-17 14:44:44 +01:00 |
|
|
Arthur Hulsman
|
3583165b30
|
Removed logic related to starting the ad by clicking/ tapping the advertisement container. Ad is started by plyr play method.
|
2018-01-17 14:09:11 +01:00 |
|
|
Arthur Hulsman
|
d822f0c6bf
|
Adsmanager is now re/pre-loaded with new ads when the video is done or an ad error appears. Will make it possible to request ads when a new video is loaded. Added comments and missing events within the adsmanagerloader method.
|
2018-01-17 13:58:39 +01:00 |
|
|
Arthur Hulsman
|
9e52296dc6
|
Moved the ads container to be outside of the video wrapper. This way we can easily move the ad in front or behind the video controls based on content resume or pause IMA events.
|
2018-01-17 12:19:32 +01:00 |
|
|
Arthur Hulsman
|
12a7a4142c
|
Moved the logic for pausing and playing the video to content pause/ resume IMA events to avoid flickering. Also used events for resolving the adsmanager and adsloader promises.
|
2018-01-17 11:32:13 +01:00 |
|
|
Arthur Hulsman
|
4b0005c28e
|
Added promises, missing events, new ad tag and additional logging.
|
2018-01-15 14:47:34 +01:00 |
|