v3.4.3

Merge pull request #1163 from sampotts/develop
Fix bug with nodeList for play buttons
2018-08-14 12:16:34 +10:00 · 2018-08-14 12:14:58 +10:00 · 2018-08-14 12:13:16 +10:00 · 2018-08-14 12:13:00 +10:00
15 changed files with 25 additions and 21 deletions
--- a/changelog.md
+++ b/changelog.md
@ -1,3 +1,7 @@
+# v3.4.3
+
+-   Fixed issue with nodeList for custom playback controls
+
 # v3.4.2

 -   Fix play/pause button state
--- a/dist/plyr.js
+++ b/dist/plyr.js
@ -2959,8 +2959,8 @@ typeof navigator === "object" && (function (global, factory) {

                // Toggle classname when pressed property is set
                Object.values(this.elements.buttons).filter(Boolean).forEach(function (button) {
-                    if (is.array(button)) {
-                        button.filter(Boolean).forEach(addProperty);
+                    if (is.array(button) || is.nodeList(button)) {
+                        Array.from(button).filter(Boolean).forEach(addProperty);
                    } else {
                        addProperty(button);
                    }
--- a/dist/plyr.js.map
+++ b/dist/plyr.js.map
--- a/dist/plyr.min.js
+++ b/dist/plyr.min.js
--- a/dist/plyr.min.js.map
+++ b/dist/plyr.min.js.map
--- a/dist/plyr.polyfilled.js
+++ b/dist/plyr.polyfilled.js
@ -8386,8 +8386,8 @@ typeof navigator === "object" && (function (global, factory) {

 	            // Toggle classname when pressed property is set
 	            Object.values(this.elements.buttons).filter(Boolean).forEach(function (button) {
-	                if (is$1.array(button)) {
-	                    button.filter(Boolean).forEach(addProperty);
+	                if (is$1.array(button) || is$1.nodeList(button)) {
+	                    Array.from(button).filter(Boolean).forEach(addProperty);
 	                } else {
 	                    addProperty(button);
 	                }
--- a/dist/plyr.polyfilled.js.map
+++ b/dist/plyr.polyfilled.js.map
--- a/dist/plyr.polyfilled.min.js
+++ b/dist/plyr.polyfilled.min.js
--- a/dist/plyr.polyfilled.min.js.map
+++ b/dist/plyr.polyfilled.min.js.map
--- a/gulpfile.js
+++ b/gulpfile.js
@ -44,7 +44,7 @@ const paths = {
        // Source paths
        src: {
            sass: path.join(root, 'src/sass/**/*.scss'),
-            js: path.join(root, 'src/js/**/*'),
+            js: path.join(root, 'src/js/**/*.js'),
            sprite: path.join(root, 'src/sprite/*.svg'),
        },

@ -55,7 +55,7 @@ const paths = {
        // Source paths
        src: {
            sass: path.join(root, 'demo/src/sass/**/*.scss'),
-            js: path.join(root, 'demo/src/js/**/*'),
+            js: path.join(root, 'demo/src/js/**/*.js'),
        },

        // Output paths
--- a/package.json
+++ b/package.json
@ -1,6 +1,6 @@
 {
    "name": "plyr",
-    "version": "3.4.2",
+    "version": "3.4.3",
    "description": "A simple, accessible and customizable HTML5, YouTube and Vimeo media player",
    "homepage": "https://plyr.io",
    "author": "Sam Potts <sam@potts.es>",
--- a/readme.md
+++ b/readme.md
@ -132,13 +132,13 @@ See [initialising](#initialising) for more information on advanced setups.
 You can use our CDN (provided by [Fastly](https://www.fastly.com/)) for the JavaScript. There's 2 versions; one with and one without [polyfills](#polyfills). My recommendation would be to manage polyfills seperately as part of your application but to make life easier you can use the polyfilled build.

 ```html
-<script src="https://cdn.plyr.io/3.4.2/plyr.js"></script>
+<script src="https://cdn.plyr.io/3.4.3/plyr.js"></script>
 ```

 ...or...

 ```html
-<script src="https://cdn.plyr.io/3.4.2/plyr.polyfilled.js"></script>
+<script src="https://cdn.plyr.io/3.4.3/plyr.polyfilled.js"></script>
 ```

 ### CSS
@ -152,13 +152,13 @@ Include the `plyr.css` stylsheet into your `<head>`
 If you want to use our CDN (provided by [Fastly](https://www.fastly.com/)) for the default CSS, you can use the following:

 ```html
-<link rel="stylesheet" href="https://cdn.plyr.io/3.4.2/plyr.css">
+<link rel="stylesheet" href="https://cdn.plyr.io/3.4.3/plyr.css">
 ```

 ### SVG Sprite

 The SVG sprite is loaded automatically from our CDN (provided by [Fastly](https://www.fastly.com/)). To change this, see the [options](#options) below. For
-reference, the CDN hosted SVG sprite can be found at `https://cdn.plyr.io/3.4.2/plyr.svg`.
+reference, the CDN hosted SVG sprite can be found at `https://cdn.plyr.io/3.4.3/plyr.svg`.

 ## Ads

--- a/src/js/controls.js
+++ b/src/js/controls.js
@ -1627,8 +1627,8 @@ const controls = {
            Object.values(this.elements.buttons)
                .filter(Boolean)
                .forEach(button => {
-                    if (is.array(button)) {
-                        button.filter(Boolean).forEach(addProperty);
+                    if (is.array(button) || is.nodeList(button)) {
+                        Array.from(button).filter(Boolean).forEach(addProperty);
                    } else {
                        addProperty(button);
                    }
--- a/src/js/plyr.js
+++ b/src/js/plyr.js
@ -1,6 +1,6 @@
 // ==========================================================================
 // Plyr
-// plyr.js v3.4.2
+// plyr.js v3.4.3
 // https://github.com/sampotts/plyr
 // License: The MIT License (MIT)
 // ==========================================================================
--- a/src/js/plyr.polyfilled.js
+++ b/src/js/plyr.polyfilled.js
@ -1,6 +1,6 @@
 // ==========================================================================
 // Plyr Polyfilled Build
-// plyr.js v3.4.2
+// plyr.js v3.4.3
 // https://github.com/sampotts/plyr
 // License: The MIT License (MIT)
 // ==========================================================================
Author	SHA1	Message	Date
Sam Potts	7dc4d9cd22	v3.4.3	2018-08-14 12:16:34 +10:00
Sam Potts	8fb8ae1260	Merge pull request #1163 from sampotts/develop Fix bug with nodeList for play buttons	2018-08-14 12:14:58 +10:00
Sam Potts	90304369f4	Fix watch	2018-08-14 12:13:16 +10:00
Sam Potts	922456c46c	Fix for nodeList as buttons	2018-08-14 12:13:00 +10:00