ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #700 from ashkanhosseini/master

Browse Source 
fix #684 memory leaks issues after destroy.
This commit is contained in:
Sam Potts 2017-11-04 18:11:35 +11:00 committed by GitHub
commit 650ee2c18f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/js/plyr.js
View File

@ -519,11 +519,11 @@
}
// Unbind event
/*function _off(element, events, callback, useCapture) {
function _off(element, events, callback, useCapture) {
if (element) {
_toggleListener(element, events, callback, false, useCapture);
}
}*/
}
// Trigger event
function _event(element, type, bubbles, properties) {
@ -2931,6 +2931,10 @@
}
}
function onBodyClick() {
_toggleClass(_getElement('.' + config.classes.tabFocus), config.classes.tabFocus, false);
}
// Listen for control events
function _controlListeners() {
// IE doesn't support input event, so we fallback to change
@ -3145,9 +3149,7 @@
checkTabFocus(focused);
}
});
_on(document.body, "click", function() {
_toggleClass(_getElement("." + config.classes.tabFocus), config.classes.tabFocus, false);
});
_on(document.body, "click", onBodyClick);
for (var button in plyr.buttons) {
var element = plyr.buttons[button];
@ -3429,9 +3431,15 @@
// Replace the container with the original element provided
plyr.container.parentNode.replaceChild(original, plyr.container);
// Free container in order for GC to remove it and prevent memory leaks due to added events
plyr.container = null;
// Allow overflow (set on fullscreen)
document.body.style.overflow = "";
//remove events
_off(document.body, 'click', onBodyClick);
// Event
_triggerEvent(original, "destroyed", true);
}