* force fullscreen events to trigger on plyr element (media element in iOS) and not fullscreen container
* Fixing "missing code in detail" for PlyrEvent type
When using typescript and listening for youtube statechange event, it is missing the code property definition inside the event (even though it is provided in the code).
By making events a map of key-value, we can add easily custom event type for specific event name. Since YouTube "statechange" event differs from the basic PlyrEvent, I added a new Event Type "PlyrStateChangeEvent" having a code property corresponding to a YoutubeState enum defined by the YouTube API documentation.
This pattern follows how addEventListener in the lib.dom.d.ts is defined.
* Update link to working dash.js demo (was broken)
* Fix PreviewThumbnailsOptions type
According to the docs, the `src` should also accept an array of strings.
* fix issue #1872
* Check if key is a string before attempt --plyr checking
* Fix for Slow loading videos not autoplaying
* Fix for Slow loading videos not autoplaying
* Network requests are not cancelled after the player is destroyed
* Fix for apect ratio problem when using Vimeo player on mobile devices (issue #1940)
* chore: update packages and linting
* Invoke custom listener on triggering fullscreen via double-click
* Fix volume when unmuting from volume 0
* adding a nice Svelte plugin that I found
* Add missing unit to calc in media query
* Assigning player's lastSeekTime on rewind/fast forward to prevent immediate controls hide on mobile
* Fix youtube not working when player is inside shadow dom
* v3.6.2
* ESLint to use common config
* add BitChute to users list
* Fix aspect ratio issue
* Revert noCookie change
* feat: demo radius tweaks
* fix: poster image shouldn’t receive click events
* chore: package updates
* chore: linting
* feat: custom controls option for embedded players
* Package upgrades
* ESLint to use common config
* Linting changes
* Update README.md
* chore: formatting
* fix: revert pointer events change for poster
* fix: hack for Safari 14 not repainting Vimeo embed on entering fullscreen
* fix: demo using custom controls for YouTube
* doc: Add STROLLÿN among the list of Plyr users
* Fixes#2005
* fix: overflowing volume slider
* chore: clean up CSS
* fix: hide poster when not using custom controls
* Package upgrades
* ESLint to use common config
* Linting changes
* chore: revert customControls default option (to prevent breaking change)
* docs: changelog for v3.6.3
* Remove unnecessary calc from media query (#2049)
* Enhance types (#1841)
* 🏷️(type) enhance QualityOptions type
Some optional properties in the QualityOptions were missing. The forced
and onChange property allwoing to use an external handler.
* ♻️(type) use Plyr.Provider for the readonly provider property
A type exists to define all available providers. This type isn't used in
the Plyr class definition and the same provider list is also defined.
This code is refactored to use the Plyr.Provider type
* 🏷️(type) add missing elements property in Plyr class
In Plyr class, you can access elements set in cache. This property is
missing in the class definition. The Plyr.Elements is for now
incomplete.
* FIX - object values for the providers must be used (#2053)
To make use of the provider configuration, the objects values must be used.
* Fix to work inside iframes. (#2069)
* Fix to work inside iframes.
Right now Plyr fails to load inside iframes because the selectors are not instances of Element (iframes have their own, separate globals). This is an alternative method to check isElement that will work inside iframes. This is battle-tested fallback code used before browsers supported HTMLElement.
* Update is.js
* Added --plyr-video-background for having control over the background of a video with alpha channel (webm) or a poster image with alpha channel. (#2076)
* Fix issue with not entering iosfullscreen of vimeo videos with playsi… (#2038)
* Fix issue with not entering iosfullscreen of vimeo videos with playsinline=true
* Use isVimeo-function instead of hardcoded value
Co-authored-by: Julian Frosch <julian.frosch@gmail.com>
* fix: use new syntax for iframe allow attribute
* Bump ini from 1.3.5 to 1.3.7 (#2044)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: package updates
* chore: add @babel/plugin-proposal-class-properties
* fix: use bound arrow functions in classes
* chore: cleanup commented out code
* chore: release
Co-authored-by: Som Meaden <som@theprojectsomething.com>
Co-authored-by: akuma06 <demon.akuma06@gmail.com>
Co-authored-by: Jonathan Arbely <dev@jonathanarbely.de>
Co-authored-by: Takeshi <iwatakeshi@users.noreply.github.com>
Co-authored-by: Hex <hex@codeigniter.org.cn>
Co-authored-by: Syed Husain <syed.husain@appspace.com>
Co-authored-by: Danielh112 <Daniel@sbgsportssoftware.com>
Co-authored-by: Danil Stoyanov <d.stoyanov@corp.mail.ru>
Co-authored-by: Guru Prasad Srinivasa <gurupras@buffalo.edu>
Co-authored-by: Stephane Fortin Bouchard <stephane.f.bouchard@gmail.com>
Co-authored-by: Zev Averbach <zev@averba.ch>
Co-authored-by: Vincent Orback <hello@vincentorback.se>
Co-authored-by: trafium <trafium@gmail.com>
Co-authored-by: xansen <27698939+xansen@users.noreply.github.com>
Co-authored-by: zoomerdev <59863739+zoomerdev@users.noreply.github.com>
Co-authored-by: Mikaël Castellani <mikael.castellani@gmail.com>
Co-authored-by: dirkjf <d.j.faber@outlook.com>
Co-authored-by: Naomi <naomizuiverloon@gmail.com>
Co-authored-by: Manuel Raynaud <manu@raynaud.io>
Co-authored-by: syteknet-core <github.core@sytek.net>
Co-authored-by: Andre Gagnon <ajgagnon@uwalumni.com>
Co-authored-by: Nepomuk Leutschacher <864660+nepomuc@users.noreply.github.com>
Co-authored-by: Elias Saalmann <lordon@users.noreply.github.com>
Co-authored-by: Julian Frosch <julian.frosch@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* force fullscreen events to trigger on plyr element (media element in iOS) and not fullscreen container
* Fixing "missing code in detail" for PlyrEvent type
When using typescript and listening for youtube statechange event, it is missing the code property definition inside the event (even though it is provided in the code).
By making events a map of key-value, we can add easily custom event type for specific event name. Since YouTube "statechange" event differs from the basic PlyrEvent, I added a new Event Type "PlyrStateChangeEvent" having a code property corresponding to a YoutubeState enum defined by the YouTube API documentation.
This pattern follows how addEventListener in the lib.dom.d.ts is defined.
* Update link to working dash.js demo (was broken)
* Fix PreviewThumbnailsOptions type
According to the docs, the `src` should also accept an array of strings.
* fix issue #1872
* Check if key is a string before attempt --plyr checking
* Fix for Slow loading videos not autoplaying
* Fix for Slow loading videos not autoplaying
* Network requests are not cancelled after the player is destroyed
* Fix for apect ratio problem when using Vimeo player on mobile devices (issue #1940)
* chore: update packages and linting
* Invoke custom listener on triggering fullscreen via double-click
* Fix volume when unmuting from volume 0
* adding a nice Svelte plugin that I found
* Add missing unit to calc in media query
* Assigning player's lastSeekTime on rewind/fast forward to prevent immediate controls hide on mobile
* Fix youtube not working when player is inside shadow dom
* v3.6.2
* ESLint to use common config
* add BitChute to users list
* Fix aspect ratio issue
* Revert noCookie change
* feat: demo radius tweaks
* fix: poster image shouldn’t receive click events
* chore: package updates
* chore: linting
* feat: custom controls option for embedded players
* Package upgrades
* ESLint to use common config
* Linting changes
* Update README.md
* chore: formatting
* fix: revert pointer events change for poster
* fix: hack for Safari 14 not repainting Vimeo embed on entering fullscreen
* fix: demo using custom controls for YouTube
* doc: Add STROLLÿN among the list of Plyr users
* Fixes#2005
* fix: overflowing volume slider
* chore: clean up CSS
* fix: hide poster when not using custom controls
* Package upgrades
* ESLint to use common config
* Linting changes
* chore: revert customControls default option (to prevent breaking change)
* docs: changelog for v3.6.3
Co-authored-by: Som Meaden <som@theprojectsomething.com>
Co-authored-by: akuma06 <demon.akuma06@gmail.com>
Co-authored-by: Jonathan Arbely <dev@jonathanarbely.de>
Co-authored-by: Takeshi <iwatakeshi@users.noreply.github.com>
Co-authored-by: Hex <hex@codeigniter.org.cn>
Co-authored-by: Syed Husain <syed.husain@appspace.com>
Co-authored-by: Danielh112 <Daniel@sbgsportssoftware.com>
Co-authored-by: Danil Stoyanov <d.stoyanov@corp.mail.ru>
Co-authored-by: Guru Prasad Srinivasa <gurupras@buffalo.edu>
Co-authored-by: Stephane Fortin Bouchard <stephane.f.bouchard@gmail.com>
Co-authored-by: Zev Averbach <zev@averba.ch>
Co-authored-by: Vincent Orback <hello@vincentorback.se>
Co-authored-by: trafium <trafium@gmail.com>
Co-authored-by: xansen <27698939+xansen@users.noreply.github.com>
Co-authored-by: zoomerdev <59863739+zoomerdev@users.noreply.github.com>
Co-authored-by: Mikaël Castellani <mikael.castellani@gmail.com>
Co-authored-by: dirkjf <d.j.faber@outlook.com>
These changes bring Plyr captions download behaviour in line with that of the default video element in major browsers. Specifically text tracks only download as they are required for display. Previously all text tracks would download when the Plyr instance was instantiated - which could become an issue when e.g. many translations are available.
For a track to be downloaded it must either be the default track, the active track when captions are toggled on, or selected from the captions menu.
Example use-cases include:
- display of video title or other metadata (see the included demo)
- alternative access to menu items, such as a searchable captions list (in cases where many hundreds of languages are available)
- custom share dialogs
- integrated playlists with 'playing next' overlays
This approach / PR is just an example of how this feature could work and aims to keep Plyr complexity to a minimum (while enabling some fairly interesting integrations). It utilises a single config option, and does away with the need for injecting bespoke APIs or elements into the player context on a per-project basis. Or trying to mess with what is a pretty slick, but tightly coupled system.
For the user: A new `fullscreen.container` attribute is used to provide a container selector. The container must be an ancestor of the player, otherwise it's ignored. When toggling fullscreen mode, this container is now used in place of the player. Hovering over any children of the container is the same as hovering over the controls. The exception is where the player and the child share a common ancestor (that's not the fullscreen container) ... sounds complex but it's not. You can also gain pretty fine control this way with pointer events.
Under the hood: it adds a `utils/elements/closest` helper method to find the right ancestor. If found this is returned as the fullscreen target in place of the player container. Fullscreen is instantiated slightly earlier in the setup so this container is available for the `listeners.controls` call. In here we add some more 'mouseenter/mouseleave' listeners to any direct descendants of the container, that aren't also ancestors of the player. And that's it. No extra classes, nothing else. There are some style changes to the demo (top margin on the player) but these would be project specific.
Thanks for reading.
SVG icons should be ignored by screen readers since they have complimentary labels (aria-label or plyr__sr-only). The current « presentation » role simply makes the element behave like a « span » which is incorrect, aria-hidden prevents screen readers from taking care of these elements at all.
