ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify currentTime setter and bail when media hasn't loaded

Browse Source
This commit is contained in:
Albin Larsson
2018-05-28 00:33:17 +02:00
parent c69aa8a42b
commit fac8a185ba
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/js/plyr.js
View File

@ -432,21 +432,16 @@ class Plyr {
* @param {number} input - where to seek to in seconds. Defaults to 0 (the start) * @param {number} input - where to seek to in seconds. Defaults to 0 (the start)
*/ */
set currentTime(input) { set currentTime(input) {
let targetTime = 0; // Bail if media duration isn't available yet
if (!this.duration) {
if (utils.is.number(input)) { return;
targetTime = input;
} }
// Normalise targetTime // Validate input
if (targetTime < 0) { const inputIsValid = utils.is.number(input) && input > 0;
targetTime = 0;
} else if (targetTime > this.duration) {
targetTime = this.duration;
}
// Set // Set
this.media.currentTime = targetTime; this.media.currentTime = inputIsValid ? Math.min(input, this.duration) : 0;
// Logging // Logging
this.debug.log(`Seeking to ${this.currentTime} seconds`); this.debug.log(`Seeking to ${this.currentTime} seconds`);