From f7d2938f4281cfa385af9221a0bf4e5515e147c5 Mon Sep 17 00:00:00 2001
From: Roy Eden <roy.ede@gmail.com>
Date: Fri, 30 Dec 2022 21:15:13 -0300
Subject: [PATCH] Fixed event key with space (#2581)

* Fixed event key with space

* Fixed spacebar `event.key` in `controls.js`
---
 src/js/controls.js  | 8 ++++----
 src/js/listeners.js | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/js/controls.js b/src/js/controls.js
index 562820d8..b15f8bb6 100644
--- a/src/js/controls.js
+++ b/src/js/controls.js
@@ -404,7 +404,7 @@ const controls = {
       'keydown keyup',
       (event) => {
         // We only care about space and ⬆️ ⬇️️ ➡️
-        if (!['Space', 'ArrowUp', 'ArrowDown', 'ArrowRight'].includes(event.key)) {
+        if (![' ', 'ArrowUp', 'ArrowDown', 'ArrowRight'].includes(event.key)) {
           return;
         }
 
@@ -420,12 +420,12 @@ const controls = {
         const isRadioButton = matches(menuItem, '[role="menuitemradio"]');
 
         // Show the respective menu
-        if (!isRadioButton && ['Space', 'ArrowRight'].includes(event.key)) {
+        if (!isRadioButton && [' ', 'ArrowRight'].includes(event.key)) {
           controls.showMenuPanel.call(this, type, true);
         } else {
           let target;
 
-          if (event.key !== 'Space') {
+          if (event.key !== ' ') {
             if (event.key === 'ArrowDown' || (isRadioButton && event.key === 'ArrowRight')) {
               target = menuItem.nextElementSibling;
 
@@ -504,7 +504,7 @@ const controls = {
       menuItem,
       'click keyup',
       (event) => {
-        if (is.keyboardEvent(event) && event.key !== 'Space') {
+        if (is.keyboardEvent(event) && event.key !== ' ') {
           return;
         }
 
diff --git a/src/js/listeners.js b/src/js/listeners.js
index 38a34400..bec84225 100644
--- a/src/js/listeners.js
+++ b/src/js/listeners.js
@@ -65,14 +65,14 @@ class Listeners {
           return;
         }
 
-        if (event.key === 'Space' && matches(focused, 'button, [role^="menuitem"]')) {
+        if (event.key === ' ' && matches(focused, 'button, [role^="menuitem"]')) {
           return;
         }
       }
 
       // Which keys should we prevent default
       const preventDefault = [
-        'Space',
+        ' ',
         'ArrowLeft',
         'ArrowUp',
         'ArrowRight',
@@ -118,7 +118,7 @@ class Listeners {
           }
           break;
 
-        case 'Space':
+        case ' ':
         case 'k':
           if (!repeat) {
             silencePromise(player.togglePlay());
@@ -663,7 +663,7 @@ class Listeners {
       elements.buttons.settings,
       'keyup',
       (event) => {
-        if (!['Space', 'Enter'].includes(event.key)) {
+        if (![' ', 'Enter'].includes(event.key)) {
           return;
         }