From ef27ba16f4d1e8520c90cecf9e945b1edebb7ec0 Mon Sep 17 00:00:00 2001 From: Albin Larsson Date: Sat, 10 Mar 2018 16:20:33 +0100 Subject: [PATCH] Add optional argument to Ads.trigger (currently only used for adblocker error) --- src/js/plugins/ads.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/js/plugins/ads.js b/src/js/plugins/ads.js index 5cf743c2..82599594 100644 --- a/src/js/plugins/ads.js +++ b/src/js/plugins/ads.js @@ -50,8 +50,9 @@ class Ads { }) .catch(() => { // Script failed to load or is blocked - this.trigger('ERROR'); - this.player.debug.error('Google IMA SDK failed to load'); + const message = 'Google IMA SDK failed to load'; + this.trigger('ERROR', new Error(message)); + this.player.debug.error(message); }); } else { this.ready(); @@ -518,13 +519,13 @@ class Ads { * Handles callbacks after an ad event was invoked * @param {string} event - Event type */ - trigger(event) { + trigger(event, ...args) { const handlers = this.events[event]; if (utils.is.array(handlers)) { handlers.forEach(handler => { if (utils.is.function(handler)) { - handler.call(this); + handler.apply(this, args); } }); }