From 800e0dedfbdc486fd2be1e5a5168a48521c22b3f Mon Sep 17 00:00:00 2001 From: Gurinder Hans Date: Sat, 23 Dec 2017 21:41:08 -0800 Subject: [PATCH 1/2] add double click to make full screen support --- src/js/plyr.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/js/plyr.js b/src/js/plyr.js index 2e200876..e4683dea 100644 --- a/src/js/plyr.js +++ b/src/js/plyr.js @@ -2229,6 +2229,9 @@ // Toggle fullscreen function _toggleFullscreen(event) { + if (plyr.type === 'audio') { + return + } // Check for native support var nativeSupport = fullscreen.supportsFullScreen; @@ -3193,6 +3196,9 @@ // Fullscreen _proxyListener(plyr.buttons.fullscreen, 'click', config.listeners.fullscreen, _toggleFullscreen); + // Toggle fullscreen when user double clicks on video wrapper + _proxyListener(plyr.container, 'dblclick', config.listeners.fullscreen, _toggleFullscreen); + // Handle user exiting fullscreen by escaping etc if (fullscreen.supportsFullScreen) { _on(document, fullscreen.fullScreenEventName, _toggleFullscreen); From 838bd49a1dae0fc79cd02d3eddff1edc046b2a3c Mon Sep 17 00:00:00 2001 From: Gurinder Hans Date: Sat, 23 Dec 2017 21:47:01 -0800 Subject: [PATCH 2/2] add comment about no fullscreen if player type is audio --- src/js/plyr.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/js/plyr.js b/src/js/plyr.js index e4683dea..afd1b997 100644 --- a/src/js/plyr.js +++ b/src/js/plyr.js @@ -2229,9 +2229,11 @@ // Toggle fullscreen function _toggleFullscreen(event) { + // We don't allow fullscreen on audio player if (plyr.type === 'audio') { return } + // Check for native support var nativeSupport = fullscreen.supportsFullScreen;