ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Using the “href” attribute on SVG if supported, using hasAttribute

Browse Source
This commit is contained in:
Sam Potts 2017-11-07 09:58:37 +11:00
parent 84505da84b
commit e2c7491ccd
5 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dist/plyr.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/plyr.js.map vendored
View File

File diff suppressed because one or more lines are too long

11
src/js/controls.js vendored
View File

@ -73,7 +73,16 @@ const controls = {
// Create the <use> to reference sprite
const use = document.createElementNS(namespace, 'use');
use.setAttributeNS('http://www.w3.org/1999/xlink', 'xlink:href', `${iconPath}-${type}`);
const path = `${iconPath}-${type}`;
// If the new `href` attribute is supported, use that
// https://github.com/sampotts/plyr/issues/460
// https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href
if ('href' in use) {
use.setAttribute('href', path);
} else {
use.setAttributeNS('http://www.w3.org/1999/xlink', 'xlink:href', path);
}
// Add <use> to <svg>
icon.appendChild(use);

4
src/js/defaults.js
View File

@ -57,8 +57,8 @@ const defaults = {
// Set loops
loop: {
active: false,
start: null,
end: null,
// start: null,
// end: null,
},
// Speed default and options to display

11
src/js/plyr.js
View File

@ -170,21 +170,22 @@ class Plyr {
case 'audio':
this.type = type;
if (this.media.getAttribute('crossorigin') !== null) {
if (this.media.hasAttribute('crossorigin')) {
this.config.crossorigin = true;
}
if (this.media.getAttribute('autoplay') !== null) {
if (this.media.hasAttribute('autoplay')) {
this.config.autoplay = true;
}
if (this.media.getAttribute('playsinline') !== null) {
if (this.media.hasAttribute('playsinline')) {
this.config.inline = true;
}
if (this.media.getAttribute('muted') !== null) {
if (this.media.hasAttribute('muted')) {
this.config.muted = true;
}
if (this.media.getAttribute('loop') !== null) {
if (this.media.hasAttribute('loop')) {
this.config.loop.active = true;
}
break;
default: