Event listener fixes, loadScript promise, ads tweaks

2018-03-11 02:03:35 +11:00
parent c734bc4957
commit e206edc1f6
25 changed files with 3559 additions and 3386 deletions
--- a/src/js/controls.js
+++ b/src/js/controls.js
@ -752,6 +752,12 @@ const controls = {
    toggleMenu(event) {
        const { form } = this.elements.settings;
        const button = this.elements.buttons.settings;
+
+        // Menu and button are required
+        if (!utils.is.element(form) || !utils.is.element(button)) {
+            return;
+        }
+
        const show = utils.is.boolean(event) ? event : utils.is.element(form) && form.getAttribute('aria-hidden') === 'true';

        if (utils.is.event(event)) {