ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1490 from antonyoneill/develop

Browse Source 
Prevent default on settings control click
This commit is contained in:
Sam Potts
2020-02-09 10:30:33 +00:00
committed by GitHub
parent 59e3ef7248 400fd77d0a
commit e1cb2f24f5
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/js/listeners.js
View File

@ -599,12 +599,19 @@ class Listeners {
this.bind(elements.buttons.airplay, 'click', player.airplay, 'airplay'); this.bind(elements.buttons.airplay, 'click', player.airplay, 'airplay');
// Settings menu - click toggle // Settings menu - click toggle
this.bind(elements.buttons.settings, 'click', event => { this.bind(
// Prevent the document click listener closing the menu elements.buttons.settings,
event.stopPropagation(); 'click',
event => {
// Prevent the document click listener closing the menu
event.stopPropagation();
event.preventDefault();
controls.toggleMenu.call(player, event); controls.toggleMenu.call(player, event);
}); },
null,
false
); // Can't be passive as we're preventing default
// Settings menu - keyboard toggle // Settings menu - keyboard toggle
// We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus