From 81c5477f1d9ac2539e4ec50ede7886abe50fa75a Mon Sep 17 00:00:00 2001 From: Albin Larsson Date: Thu, 21 Jun 2018 15:22:30 +0200 Subject: [PATCH 1/2] Fix captions.toggle() if there is no toggle button --- src/js/captions.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/js/captions.js b/src/js/captions.js index 732b2e38..9dca5505 100644 --- a/src/js/captions.js +++ b/src/js/captions.js @@ -191,8 +191,10 @@ const captions = { return; } - // Toggle state - this.elements.buttons.captions.pressed = active; + // Toggle button if it's enabled + if (this.elements.buttons.captions) { + this.elements.buttons.captions.pressed = active; + } // Add class hook toggleClass(this.elements.container, activeClass, active); From b6ddf144f4b6d784da68a322de6e44b6fe724409 Mon Sep 17 00:00:00 2001 From: Michael DePetrillo Date: Mon, 25 Jun 2018 12:00:02 +0200 Subject: [PATCH 2/2] handle undefined player.elements.buttons.play --- src/js/listeners.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/js/listeners.js b/src/js/listeners.js index d9811dd1..7615e365 100644 --- a/src/js/listeners.js +++ b/src/js/listeners.js @@ -431,9 +431,11 @@ class Listeners { }; // Play/pause toggle - Array.from(this.player.elements.buttons.play).forEach(button => { - bind(button, 'click', this.player.togglePlay, 'play'); - }); + if (this.player.elements.buttons.play) { + Array.from(this.player.elements.buttons.play).forEach(button => { + bind(button, 'click', this.player.togglePlay, 'play'); + }); + } // Pause bind(this.player.elements.buttons.restart, 'click', this.player.restart, 'restart');