From c634d3696e625237926e339f5ffe2ef9b8789804 Mon Sep 17 00:00:00 2001 From: Tobias Reich Date: Thu, 14 Feb 2019 13:16:10 +0100 Subject: [PATCH 1/2] Remove NodeList example I've removed the NodeList example because it's confusing. Only the first element of a NodeList will be used and this is usually not what you want. I've instead replaced it with a `querySelector` and map example. It's related to: https://github.com/sampotts/plyr/issues/801 I know that there was a note, pointing out that the first element will be used, but be honest: Everybody is just scanning the examples for code and doing copy paste :D --- readme.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/readme.md b/readme.md index 6d55989c..708aac1f 100644 --- a/readme.md +++ b/readme.md @@ -229,7 +229,6 @@ You can specify a range of arguments for the constructor to use: - A CSS string selector that's compatible with [`querySelector`](https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector) - A [`HTMLElement`](https://developer.mozilla.org/en/docs/Web/API/HTMLElement) -- A [`NodeList`](https://developer.mozilla.org/en-US/docs/Web/API/NodeList) - A [jQuery](https://jquery.com) object _Note_: If a `NodeList`, `Array`, or jQuery object are passed, the first element will be used for setup. To setup multiple players, see [setting up multiple players](#setting-up-multiple-players) below. @@ -248,13 +247,15 @@ Passing a [HTMLElement](https://developer.mozilla.org/en/docs/Web/API/HTMLElemen const player = new Plyr(document.getElementById('player')); ``` -Passing a [NodeList](https://developer.mozilla.org/en-US/docs/Web/API/NodeList) (see note below): - ```javascript -const player = new Plyr(document.querySelectorAll('.js-player')); +const player = new Plyr(document.querySelector('#player')); ``` -The NodeList, HTMLElement or string selector can be the target `