From 10f366fe32348259c9bb15cfdb7feeffcb3f0278 Mon Sep 17 00:00:00 2001 From: Nisar Hassan Naqvi Date: Mon, 16 Mar 2020 07:16:22 +0000 Subject: [PATCH 1/3] update the gitpod setup description to be more precise. --- .gitpod.yml | 2 +- contributing.md | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.gitpod.yml b/.gitpod.yml index ded36866..c4a67050 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -1,5 +1,5 @@ tasks: - - init: npm install && npm i gulp -g + - before: npm install && npm i gulp -g command: gulp ports: - port: 3000 diff --git a/contributing.md b/contributing.md index b1bcc315..38884f3a 100644 --- a/contributing.md +++ b/contributing.md @@ -29,9 +29,15 @@ Please follow the instructions in our issue templates. Don't use github issues t * To test locally, you can use the demo site. First make sure you have installed the dependencies with `npm install` or `yarn`. Run `gulp` to build and it will run a local web server for development and watch for any changes. -### Online one-click setup +### Online one-click setup for contributing -Alternatively can also use Gitpod, a free online Visual Studio Code-like IDE. With a single click it will automatically launch a ready-to-code workspace with all the dependencies pre-installed, gulp watching for changes and the web server running, so that you can start coding straightaway. +You can use Gitpod (a free online VS Code-like IDE) for contributing. With a single click it will launch a workspace and automatically: + +- clone the plyr repo. +- install the dependencies. +- run `gulp` to the start the server. + +So that you can start straight away. [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) From d63182ecd52ba1193d85c8419b8dc7b84730857c Mon Sep 17 00:00:00 2001 From: xufanglu <3146974+likev@users.noreply.github.com> Date: Tue, 21 Apr 2020 23:06:06 +0800 Subject: [PATCH 2/3] Update readme.md There is another same Note below --- readme.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/readme.md b/readme.md index a5acb614..20a46a86 100644 --- a/readme.md +++ b/readme.md @@ -501,8 +501,6 @@ player.source = { }; ``` -_Note_: `src` can be the video ID or URL - Vimeo example ```javascript From d2fa69bca6f2497c7d2c090e8ff1e1ae1760f7bc Mon Sep 17 00:00:00 2001 From: xufanglu <3146974+likev@users.noreply.github.com> Date: Tue, 21 Apr 2020 23:25:00 +0800 Subject: [PATCH 3/3] Update readme.md fixed code logic error --- readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.md b/readme.md index a5acb614..2e9852bc 100644 --- a/readme.md +++ b/readme.md @@ -674,7 +674,7 @@ The `enabled` option can be used to disable certain User Agents. For example, if ```javascript { - enabled: /Android|webOS|iPhone|iPad|iPod|BlackBerry/i.test(navigator.userAgent); + enabled: !/Android|webOS|iPhone|iPad|iPod|BlackBerry/i.test(navigator.userAgent); } ```