From 93f5acbffd32fc016ca0b0b3679ba9184d12009f Mon Sep 17 00:00:00 2001 From: Sam Potts Date: Sun, 2 Jun 2019 22:25:00 +1000 Subject: [PATCH] Fixed cite display --- demo/src/js/demo.js | 6 ++++-- demo/src/sass/components/players.scss | 14 -------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/demo/src/js/demo.js b/demo/src/js/demo.js index 93ffe172..a0a6ab1a 100644 --- a/demo/src/js/demo.js +++ b/demo/src/js/demo.js @@ -231,9 +231,11 @@ import Plyr from '../../../src/js/plyr'; // Show cite Array.from(document.querySelectorAll('.plyr__cite')).forEach(cite => { - cite.setAttribute('hidden', ''); + // eslint-disable-next-line no-param-reassign + cite.hidden = true; }); - document.querySelector(`.plyr__cite--${type}`).removeAttribute('hidden'); + + document.querySelector(`.plyr__cite--${type}`).hidden = false; } // Bind to each button diff --git a/demo/src/sass/components/players.scss b/demo/src/sass/components/players.scss index d088a91d..966a6343 100644 --- a/demo/src/sass/components/players.scss +++ b/demo/src/sass/components/players.scss @@ -2,12 +2,6 @@ // Examples // ========================================================================== -// For non supported browsers -video { - max-width: 100%; - vertical-align: middle; -} - // Example players .plyr { border-radius: $border-radius-base; @@ -34,17 +28,9 @@ video { // Style full supported player .plyr__cite { - display: none; margin-top: $spacing-base; .icon { margin-right: ceil($spacing-base / 6); } } - -.plyr--video:not(.plyr--youtube):not(.plyr--vimeo) ~ ul .plyr__cite--video, -.plyr--audio ~ ul .plyr__cite--audio, -.plyr--youtube ~ ul .plyr__cite--youtube, -.plyr--vimeo ~ ul .plyr__cite--vimeo { - display: block; -}