Merge pull request #1197 from TechGuard/fix-html5-quality-settings

Fix html5 quality settings
This commit is contained in:
Sam Potts 2018-10-24 22:39:34 +11:00 committed by GitHub
commit 88528ef979
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions

View File

@ -82,9 +82,6 @@ const html5 = {
triggerEvent.call(player, player.media, 'qualitychange', false, { triggerEvent.call(player, player.media, 'qualitychange', false, {
quality: input, quality: input,
}); });
// Save to storage
player.storage.set({ quality: input });
}, },
}); });
}, },

View File

@ -696,10 +696,15 @@ class Plyr {
config.default, config.default,
].find(is.number); ].find(is.number);
let updateStorage = true;
if (!options.includes(quality)) { if (!options.includes(quality)) {
const value = closest(options, quality); const value = closest(options, quality);
this.debug.warn(`Unsupported quality option: ${quality}, using ${value} instead`); this.debug.warn(`Unsupported quality option: ${quality}, using ${value} instead`);
quality = value; quality = value;
// Don't update storage if quality is not supported
updateStorage = false;
} }
// Update config // Update config
@ -707,6 +712,11 @@ class Plyr {
// Set quality // Set quality
this.media.quality = quality; this.media.quality = quality;
// Save to storage
if (updateStorage) {
this.storage.set({ quality: quality });
}
// Seek to duration before changing quality // Seek to duration before changing quality
this.seek = duration; this.seek = duration;