ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix loading/playing of the ads when there is no valid ads.tagUrl

Browse Source
This commit is contained in:
ferdiemmen
2018-01-17 08:31:36 +01:00
parent ec73d34bd3
commit 8348f79742
4 changed files with 20 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/js/plugins/ads.js
View File

@ -21,8 +21,8 @@ const getStartEvents = () => {
class Ads {
constructor(player) {
this.player = player;
this.isPlaying = false;
this.isInitialized = false;
this.playing = false;
this.initialized = false;
// Check if a tag URL is provided.
if (!utils.is.url(player.config.ads.tagUrl)) {
@ -39,22 +39,6 @@ class Ads {
}
}
set playing(bool = false) {
this.isPlaying = bool;
}
get playing() {
return this.isPlaying;
}
set initialized(bool = false) {
this.isInitialized = bool;
}
get initialized() {
return this.isInitialized;
}
ready() {
this.time = Date.now();
this.startEvents = getStartEvents();
@ -298,10 +282,7 @@ class Ads {
onAdError(adErrorEvent) {
this.cancel();
if (this.player.debug) {
throw new Error(adErrorEvent);
}
this.player.debug.log(`[${(Date.now() - this.time) / 1000}s][IMA SDK] ERROR |`, adErrorEvent);
}
setupAdDisplayContainer() {