From bc8a25d0da8720878fbb845b08e1f8170c3d24f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benoi=CC=82t=20Burgener?= <benoit.burgener@gmail.com>
Date: Tue, 25 Feb 2020 10:46:31 +0100
Subject: [PATCH] Completely hide SVG icons to screen readers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

SVG icons should be ignored by screen readers since they have complimentary labels (aria-label or plyr__sr-only). The current « presentation » role simply makes the element behave like a « span » which is incorrect, aria-hidden prevents screen readers from taking care of these elements at all.
---
 src/js/controls.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/js/controls.js b/src/js/controls.js
index 66ec7139..37df497f 100644
--- a/src/js/controls.js
+++ b/src/js/controls.js
@@ -111,7 +111,7 @@ const controls = {
         setAttributes(
             icon,
             extend(attributes, {
-                role: 'presentation',
+                'aria-hidden': 'true',
                 focusable: 'false',
             }),
         );