Comments about keydown vs keyup for Firefox

dist/plyr.js

@@ -1691,6 +1691,8 @@ typeof navigator === "object" && (function (global, factory) {
 
 
         // Bind keyboard shortcuts for a menu item
+        // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
         bindMenuItemShortcuts: function bindMenuItemShortcuts(menuItem, type) {
             var _this = this;
 
@@ -4884,6 +4886,8 @@ typeof navigator === "object" && (function (global, factory) {
                 });
 
                 // Settings menu - keyboard toggle
+                // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
+                // https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
                 this.bind(player.elements.buttons.settings, 'keyup', function (event) {
                     // We only care about space and return
                     if (event.which !== 32 && event.which !== 13) {

src/js/controls.js

@@ -448,6 +448,8 @@ const controls = {
     },
 
     // Bind keyboard shortcuts for a menu item
+    // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
+    // https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
     bindMenuItemShortcuts(menuItem, type) {
         // Handle space or -> to open menu
         on(

src/js/listeners.js

@@ -6,7 +6,14 @@ import controls from './controls';
 import ui from './ui';
 import { repaint } from './utils/animation';
 import browser from './utils/browser';
-import { getElement, getElements, hasClass, matches, toggleClass, toggleHidden } from './utils/elements';
+import {
+    getElement,
+    getElements,
+    hasClass,
+    matches,
+    toggleClass,
+    toggleHidden,
+} from './utils/elements';
 import { on, once, toggleListener, triggerEvent } from './utils/events';
 import is from './utils/is';
 
@@ -690,6 +697,8 @@ class Listeners {
         });
 
         // Settings menu - keyboard toggle
+        // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
         this.bind(
             player.elements.buttons.settings,
             'keyup',