ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Comments about keydown vs keyup for Firefox

Browse Source
This commit is contained in:
Sam Potts
2018-08-01 00:38:19 +10:00
parent 56a485bac6
commit 748aa5179f
5 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dist/plyr.js vendored
View File

@ -1691,6 +1691,8 @@ typeof navigator === "object" && (function (global, factory) {
// Bind keyboard shortcuts for a menu item
// We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
// https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
bindMenuItemShortcuts: function bindMenuItemShortcuts(menuItem, type) {
var _this = this;
@ -4884,6 +4886,8 @@ typeof navigator === "object" && (function (global, factory) {
});
// Settings menu - keyboard toggle
// We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus
// https://bugzilla.mozilla.org/show_bug.cgi?id=1220143
this.bind(player.elements.buttons.settings, 'keyup', function (event) {
// We only care about space and return
if (event.which !== 32 && event.which !== 13) {