ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix for destroy

Browse Source
This commit is contained in:
Sam Potts
2017-11-09 20:54:14 +11:00
parent 4879bea4a0
commit 743c84188e
3 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dist/plyr.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/plyr.js.map vendored
View File

File diff suppressed because one or more lines are too long

25
src/js/plyr.js
View File

@ -922,16 +922,23 @@ class Plyr {
// If it's a soft destroy, make minimal changes
if (soft) {
utils.removeElement(this.elements.captions);
Array.from(this.elements.buttons.play).forEach(button => utils.removeElement(button));
utils.removeElement(this.elements.controls);
utils.removeElement(this.elements.wrapper);
if (Object.keys(this.elements).length) {
// Remove buttons
if (this.elements.buttons && this.elements.buttons.play) {
Array.from(this.elements.buttons.play).forEach(button => utils.removeElement(button));
}
// Clear for GC
this.elements.captions = null;
this.elements.controls = null;
this.elements.buttons.play = null;
this.elements.wrapper = null;
// Remove others
utils.removeElement(this.elements.captions);
utils.removeElement(this.elements.controls);
utils.removeElement(this.elements.wrapper);
// Clear for GC
this.elements.buttons.play = null;
this.elements.captions = null;
this.elements.controls = null;
this.elements.wrapper = null;
}
// Callback
if (utils.is.function(callback)) {