From 72afffbc8d354f7c7150a5726c9017cfef55d93a Mon Sep 17 00:00:00 2001 From: Jimmy Jia Date: Wed, 25 Sep 2019 14:21:13 -0400 Subject: [PATCH 1/2] fix: Fix handling listener return value --- src/js/listeners.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/listeners.js b/src/js/listeners.js index c5076ff3..354dc605 100644 --- a/src/js/listeners.js +++ b/src/js/listeners.js @@ -513,7 +513,7 @@ class Listeners { } // Only call default handler if not prevented in custom handler - if (returned && is.function(defaultHandler)) { + if (returned !== false && is.function(defaultHandler)) { defaultHandler.call(player, event); } } From 80a077c50af3090e1f71361ef30d286f6eb9f3b0 Mon Sep 17 00:00:00 2001 From: Pieter-Jan Baert Date: Fri, 6 Dec 2019 16:00:48 +0100 Subject: [PATCH 2/2] Typo in readme --- readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.md b/readme.md index a115a8ab..94eb5d88 100644 --- a/readme.md +++ b/readme.md @@ -276,7 +276,7 @@ Note the single quotes encapsulating the JSON and double quotes on the object ke | `enabled` | Boolean | `true` | Completely disable Plyr. This would allow you to do a User Agent check or similar to programmatically enable or disable Plyr for a certain UA. Example below. | | `debug` | Boolean | `false` | Display debugging information in the console | | `controls` | Array, Function or Element | `['play-large', 'play', 'progress', 'current-time', 'mute', 'volume', 'captions', 'settings', 'pip', 'airplay', 'fullscreen']` | If a function is passed, it is assumed your method will return either an element or HTML string for the controls. Three arguments will be passed to your function; `id` (the unique id for the player), `seektime` (the seektime step in seconds), and `title` (the media title). See [controls.md](controls.md) for more info on how the html needs to be structured. | -| `settings` | Array | `['captions', 'quality', 'speed', 'loop']` | If you're using the default controls are used then you can specify which settings to show in the menu | +| `settings` | Array | `['captions', 'quality', 'speed', 'loop']` | If the default controls are used, you can specify which settings to show in the menu | | `i18n` | Object | See [defaults.js](/src/js/config/defaults.js) | Used for internationalization (i18n) of the text within the UI. | | `loadSprite` | Boolean | `true` | Load the SVG sprite specified as the `iconUrl` option (if a URL). If `false`, it is assumed you are handling sprite loading yourself. | | `iconUrl` | String | `null` | Specify a URL or path to the SVG sprite. See the [SVG section](#svg) for more info. |