ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed captions being read by screen readers

Browse Source
This commit is contained in:
Sam Potts 2015-08-11 22:38:06 +10:00
parent bf0c81b484
commit 60c53a5894
7 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelog.md
View File

@ -1,5 +1,8 @@
# Changelog
# v1.3.3
- Removed captions being read by screen readers
# v1.3.2
- Voiceover fix for captions

2
dist/plyr.js vendored
View File

File diff suppressed because one or more lines are too long

2
docs/error.html
View File

@ -6,7 +6,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Docs styles -->
<link rel="stylesheet" href="//cdn.plyr.io/1.3.2/docs.css">
<link rel="stylesheet" href="//cdn.plyr.io/1.3.3/docs.css">
</head>
<body>
<main>

10
docs/index.html
View File

@ -8,10 +8,10 @@
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Styles -->
<link rel="stylesheet" href="https://cdn.plyr.io/1.3.2/plyr.css?3">
<link rel="stylesheet" href="https://cdn.plyr.io/1.3.3/plyr.css?3">
<!-- Docs styles -->
<link rel="stylesheet" href="https://cdn.plyr.io/1.3.2/docs.css?1">
<link rel="stylesheet" href="https://cdn.plyr.io/1.3.3/docs.css?1">
</head>
<body>
<header>
@ -97,13 +97,13 @@
b.insertBefore(c, b.childNodes[0]);
}
}
})(document, "https://cdn.plyr.io/1.3.2/sprite.svg");
})(document, "https://cdn.plyr.io/1.3.3/sprite.svg");
</script>
<!-- Plyr core script -->
<script src="https://cdn.plyr.io/1.3.2/plyr.js?1"></script>
<script src="https://cdn.plyr.io/1.3.3/plyr.js?1"></script>
<!-- Docs script -->
<script src="https://cdn.plyr.io/1.3.2/docs.js?1"></script>
<script src="https://cdn.plyr.io/1.3.3/docs.js?1"></script>
</body>
</html>

2
package.json
View File

@ -1,6 +1,6 @@
{
"name": "plyr",
"version": "1.3.2",
"version": "1.3.3",
"description": "A simple HTML5 media player using custom controls",
"homepage": "http://plyr.io",
"main": "gulpfile.js",

8
readme.md
View File

@ -40,7 +40,7 @@ If you have any cool ideas or features, please let me know by [creating an issue
Check `docs/index.html` and `docs/dist/docs.js` for an example setup.
**Heads up**, the example `index.html` file needs to be served from a webserver (such as Apache, Nginx, IIS or similar) unless you change the file sources to include http or https. e.g. change `//cdn.plyr.io/1.3.2/plyr.js` to `https://cdn.plyr.io/1.3.2/plyr.js`
**Heads up**, the example `index.html` file needs to be served from a webserver (such as Apache, Nginx, IIS or similar) unless you change the file sources to include http or https. e.g. change `//cdn.plyr.io/1.3.3/plyr.js` to `https://cdn.plyr.io/1.3.3/plyr.js`
### Bower
If bower is your thang, you can grab Plyr using:
@ -60,11 +60,11 @@ More info is on [npm](https://www.npmjs.com/package/ember-cli-plyr) and [GitHub]
If you want to use our CDN, you can use the following:
```html
<link rel="stylesheet" href="https://cdn.plyr.io/1.3.2/plyr.css">
<script src="https://cdn.plyr.io/1.3.2/plyr.js"></script>
<link rel="stylesheet" href="https://cdn.plyr.io/1.3.3/plyr.css">
<script src="https://cdn.plyr.io/1.3.3/plyr.js"></script>
```
You can also access the `sprite.svg` file at `https://cdn.plyr.io/1.3.2/sprite.svg`.
You can also access the `sprite.svg` file at `https://cdn.plyr.io/1.3.3/sprite.svg`.
### CSS
If you want to use the default css, add the `plyr.css` file from /dist into your head, or even better use `plyr.less` or `plyr.sass` file included in `/src` in your build to save a request.

5
src/js/plyr.js
View File

@ -1,6 +1,6 @@
// ==========================================================================
// Plyr
// plyr.js v1.3.2
// plyr.js v1.3.3
// https://github.com/selz/plyr
// License: The MIT License (MIT)
// ==========================================================================
@ -928,6 +928,7 @@
rel: 0,
showinfo: 0,
iv_load_policy: 3,
cc_load_policy: (config.captions.defaultActive ? 1 : 0),
cc_lang_pref: "en",
wmode: "transparent",
modestbranding: 1,
@ -1028,7 +1029,7 @@
function _setupCaptions() {
if(player.type === "video") {
// Inject the container
player.videoContainer.insertAdjacentHTML("afterbegin", "<div class='" + config.selectors.captions.replace(".", "") + "' aria-live='assertive' aria-relevant='additions text'><span></span></div>");
player.videoContainer.insertAdjacentHTML("afterbegin", "<div class='" + config.selectors.captions.replace(".", "") + "'><span></span></div>");
// Cache selector
player.captionsContainer = _getElement(config.selectors.captions).querySelector("span");