ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent default on settings icon click

Browse Source
This commit is contained in:
Antony O'Neill 2019-07-04 19:02:22 +01:00
parent dfc09b8e04
commit 400fd77d0a
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/js/listeners.js
View File

@ -603,12 +603,19 @@ class Listeners {
this.bind(elements.buttons.airplay, 'click', player.airplay, 'airplay'); this.bind(elements.buttons.airplay, 'click', player.airplay, 'airplay');
// Settings menu - click toggle // Settings menu - click toggle
this.bind(elements.buttons.settings, 'click', event => { this.bind(
elements.buttons.settings,
'click',
event => {
// Prevent the document click listener closing the menu // Prevent the document click listener closing the menu
event.stopPropagation(); event.stopPropagation();
event.preventDefault();
controls.toggleMenu.call(player, event); controls.toggleMenu.call(player, event);
}); },
null,
false
); // Can't be passive as we're preventing default
// Settings menu - keyboard toggle // Settings menu - keyboard toggle
// We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus // We have to bind to keyup otherwise Firefox triggers a click when a keydown event handler shifts focus