ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1811 from taylorchu/better-control-2

Browse Source 
allow custom control as element
This commit is contained in:
Sam Potts 2020-04-29 09:39:50 +10:00 committed by GitHub
commit 391b9acd98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/js/controls.js vendored
View File

@ -1263,7 +1263,7 @@ const controls = {
this.elements.controls = null;
// Larger overlaid play button
if (this.config.controls.includes('play-large')) {
if (is.array(this.config.controls) && this.config.controls.includes('play-large')) {
this.elements.container.appendChild(createButton.call(this, 'play-large'));
}
@ -1275,7 +1275,7 @@ const controls = {
const defaultAttributes = { class: 'plyr__controls__item' };
// Loop through controls in order
dedupe(this.config.controls).forEach(control => {
dedupe(is.array(this.config.controls) ? this.config.controls: []).forEach(control => {
// Restart button
if (control === 'restart') {
container.appendChild(createButton.call(this, 'restart', defaultAttributes));
@ -1675,8 +1675,6 @@ const controls = {
if (update) {
if (is.string(this.config.controls)) {
container = replace(container);
} else if (is.element(container)) {
container.innerHTML = replace(container.innerHTML);
}
}

2
src/js/plyr.js
View File

@ -1054,7 +1054,7 @@ class Plyr {
const hiding = toggleClass(this.elements.container, this.config.classNames.hideControls, force);
// Close menu
if (hiding && this.config.controls.includes('settings') && !is.empty(this.config.settings)) {
if (hiding && is.array(this.config.controls) && this.config.controls.includes('settings') && !is.empty(this.config.settings)) {
controls.toggleMenu.call(this, false);
}