ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #670 from friday/fix/errors-without-settings-pane

Browse Source 
Avoid errors when initiating plyr without settings (v3)
This commit is contained in:
Sam Potts 2017-09-27 23:32:25 +10:00 committed by GitHub
commit 2e5cc272e3
1 changed files with 30 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/js/plyr.js
View File

@ -1948,7 +1948,9 @@
player.elements.controls = controls; player.elements.controls = controls;
//setLoopMenu(); //setLoopMenu();
if (utils.inArray(player.config.controls, 'settings') && utils.inArray(player.config.settings, 'speed')) {
setSpeedMenu(); setSpeedMenu();
}
return controls; return controls;
} }
@ -2101,6 +2103,7 @@
// Update the selected setting // Update the selected setting
function updateSetting(setting, list) { function updateSetting(setting, list) {
var pane = player.elements.settings.panes[setting];
var value = null; var value = null;
switch (setting) { switch (setting) {
@ -2131,11 +2134,11 @@
// Get the list if we need to // Get the list if we need to
if (!utils.is.htmlElement(list)) { if (!utils.is.htmlElement(list)) {
list = player.elements.settings.panes[setting].querySelector('ul'); list = pane && pane.querySelector('ul');
} }
// Find the radio option // Find the radio option
var target = list.querySelector('input[value="' + value + '"]'); var target = list && list.querySelector('input[value="' + value + '"]');
if (!utils.is.htmlElement(target)) { if (!utils.is.htmlElement(target)) {
return; return;
@ -2367,7 +2370,9 @@
player.captions.tracks = null; player.captions.tracks = null;
// Clear menu and hide // Clear menu and hide
if (utils.inArray(player.config.controls, 'settings') && utils.inArray(player.config.settings, 'captions')) {
setCaptionsMenu(); setCaptionsMenu();
}
return; return;
} }
@ -2463,8 +2468,10 @@
} }
// Set available languages in list // Set available languages in list
if (utils.inArray(player.config.controls, 'settings') && utils.inArray(player.config.settings, 'captions')) {
setCaptionsMenu(); setCaptionsMenu();
} }
}
// Get current selected caption language // Get current selected caption language
function getLanguage() { function getLanguage() {
@ -3050,7 +3057,9 @@
player.media.muted = instance.isMuted(); player.media.muted = instance.isMuted();
// Get available speeds // Get available speeds
if (utils.inArray(player.config.controls, 'settings') && utils.inArray(player.config.settings, 'speed')) {
setSpeedMenu(instance.getAvailablePlaybackRates(), instance.getPlaybackRate()); setSpeedMenu(instance.getAvailablePlaybackRates(), instance.getPlaybackRate());
}
// Set title // Set title
player.config.title = instance.getVideoData().title; player.config.title = instance.getVideoData().title;
@ -3376,10 +3385,10 @@
function toggleMenu(event) { function toggleMenu(event) {
var form = player.elements.settings.form; var form = player.elements.settings.form;
var button = player.elements.buttons.settings; var button = player.elements.buttons.settings;
var show = utils.is.boolean(event) ? event : form.getAttribute('aria-hidden') === 'true'; var show = utils.is.boolean(event) ? event : (form && form.getAttribute('aria-hidden') === 'true');
if (utils.is.event(event)) { if (utils.is.event(event)) {
var isMenuItem = form.contains(event.target); var isMenuItem = form && form.contains(event.target);
var isButton = event.target === player.elements.buttons.settings; var isButton = event.target === player.elements.buttons.settings;
// If the click was inside the form or if the click // If the click was inside the form or if the click
@ -3396,15 +3405,18 @@
} }
// Set form and button attributes // Set form and button attributes
form.setAttribute('aria-hidden', !show); if (button) {
button.setAttribute('aria-expanded', show); button.setAttribute('aria-expanded', show);
}
if (form) {
form.setAttribute('aria-hidden', !show);
if (show) { if (show) {
form.removeAttribute('tabindex'); form.removeAttribute('tabindex');
} else { } else {
form.setAttribute('tabindex', -1); form.setAttribute('tabindex', -1);
} }
} }
}
// Get the natural size of a tab // Get the natural size of a tab
function getTabSize(tab) { function getTabSize(tab) {
@ -5579,8 +5591,10 @@
// Trigger event and close menu // Trigger event and close menu
if (toggled) { if (toggled) {
player.core.trigger(player.media, 'controlshidden'); player.core.trigger(player.media, 'controlshidden');
if (utils.inArray(player.config.controls, 'settings') && !utils.is.empty(player.config.settings)) {
player.core.toggleMenu(false); player.core.toggleMenu(false);
} }
}
}, delay); }, delay);
} }