From c7b5aa91970995271c687cac2489173c8975aadf Mon Sep 17 00:00:00 2001 From: Manuel Raynaud Date: Wed, 7 Aug 2019 17:52:22 +0200 Subject: [PATCH 1/4] =?UTF-8?q?=E2=99=BF=EF=B8=8F(controls)=20change=20pla?= =?UTF-8?q?y=20button=20aria-label=20value=20when=20its=20state=20change?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The aria-label attribute set on all play buttons does not change according the player state. When the video is playing, the aria-label should change to pause otherwise screen reader will not detect that this button now can be used to pause the video. --- src/js/ui.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/js/ui.js b/src/js/ui.js index 953ecba2..9febab8b 100644 --- a/src/js/ui.js +++ b/src/js/ui.js @@ -214,6 +214,7 @@ const ui = { // Set state Array.from(this.elements.buttons.play || []).forEach(target => { Object.assign(target, { pressed: this.playing }); + target.setAttribute('aria-label', i18n.get(this.playing ? 'pause' : 'play', this.config)); }); // Only update controls on non timeupdate events From 7907652bc9125006447069a42590a3df9245e57e Mon Sep 17 00:00:00 2001 From: Baskerville* Date: Fri, 6 Sep 2019 16:18:40 +0800 Subject: [PATCH 2/4] Update defaults.js update defaults.i18n --- src/js/config/defaults.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/js/config/defaults.js b/src/js/config/defaults.js index c50a8900..197554a2 100644 --- a/src/js/config/defaults.js +++ b/src/js/config/defaults.js @@ -164,6 +164,7 @@ const defaults = { frameTitle: 'Player for {title}', captions: 'Captions', settings: 'Settings', + pip: 'PIP', menuBack: 'Go back to previous menu', speed: 'Speed', normal: 'Normal', From 627df20b6d50e6f9d9ae9e0cadddacd3a6f83ba1 Mon Sep 17 00:00:00 2001 From: Dustin Harrell Date: Mon, 23 Sep 2019 18:26:49 -0400 Subject: [PATCH 3/4] #615: updates to vimeo and youtube plugins to ensure that loading classes are added as content is buffering --- src/js/plugins/vimeo.js | 8 ++++++++ src/js/plugins/youtube.js | 6 ++++++ 2 files changed, 14 insertions(+) diff --git a/src/js/plugins/vimeo.js b/src/js/plugins/vimeo.js index 91019abf..8df5ad15 100644 --- a/src/js/plugins/vimeo.js +++ b/src/js/plugins/vimeo.js @@ -335,6 +335,14 @@ const vimeo = { } }); + player.embed.on('bufferstart', () => { + triggerEvent.call(player, player.media, 'waiting'); + }); + + player.embed.on('bufferend', () => { + triggerEvent.call(player, player.media, 'playing'); + }); + player.embed.on('play', () => { assurePlaybackState.call(player, true); triggerEvent.call(player, player.media, 'playing'); diff --git a/src/js/plugins/youtube.js b/src/js/plugins/youtube.js index 31d22bb4..ba5d8de9 100644 --- a/src/js/plugins/youtube.js +++ b/src/js/plugins/youtube.js @@ -416,6 +416,12 @@ const youtube = { break; + case 3: + // Trigger waiting event to add loading classes to container as the video buffers. + triggerEvent.call(player, player.media, 'waiting'); + + break; + default: break; } From 12e5099c921334a1c0b092fb965b4c9ee8c8bc8e Mon Sep 17 00:00:00 2001 From: Broc Seib Date: Tue, 1 Oct 2019 17:24:57 -0400 Subject: [PATCH 4/4] Preserve viewBox attribute in SVG sprite symbols When generating the SVG sprite (using imagemin and svstore) the imagemin step needs to NOT cleanup/remove the viewBox attributes from the individual svg files. fixes #1306 --- gulpfile.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gulpfile.js b/gulpfile.js index 2623ebaf..3a4c7bdf 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -222,7 +222,11 @@ Object.entries(build.sprite).forEach(([filename, entry]) => { gulp .src(src) .pipe(plumber()) - .pipe(imagemin()) + .pipe(imagemin([ + imagemin.svgo({ + plugins: [{ removeViewBox: false }] + }) + ])) .pipe(svgstore()) .pipe(rename({ basename: path.parse(filename).name })) .pipe(size(sizeOptions))