ProximaEntertainment/plyr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

controls.createMenuItem: Change input to object (too many params made it hard to read)

Browse Source
This commit is contained in:
Albin Larsson 2018-06-09 14:14:34 +02:00
parent 9dc0f28800
commit 1fab4919c0
1 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/js/controls.js vendored
View File

@ -376,7 +376,7 @@ const controls = {
}, },
// Create a settings menu item // Create a settings menu item
createMenuItem(value, list, type, title, badge = null, checked = false) { createMenuItem({value, list, type, title, badge = null, checked = false}) {
const item = utils.createElement('li'); const item = utils.createElement('li');
const label = utils.createElement('label', { const label = utils.createElement('label', {
@ -680,8 +680,13 @@ const controls = {
return sorting.indexOf(a) > sorting.indexOf(b) ? 1 : -1; return sorting.indexOf(a) > sorting.indexOf(b) ? 1 : -1;
}) })
.forEach(quality => { .forEach(quality => {
const label = controls.getLabel.call(this, 'quality', quality); controls.createMenuItem.call(this, {
controls.createMenuItem.call(this, quality, list, type, label, getBadge(quality)); value: quality,
list,
type,
title: controls.getLabel.call(this, 'quality', quality),
badge: getBadge(quality),
});
}); });
controls.updateSetting.call(this, type, list); controls.updateSetting.call(this, type, list);
@ -861,15 +866,14 @@ const controls = {
// Generate options // Generate options
tracks.forEach(track => { tracks.forEach(track => {
controls.createMenuItem.call( controls.createMenuItem.call(this, {
this, value: track.language,
track.language,
list, list,
'language', type: 'language',
track.label, title: track.label,
track.language !== 'enabled' ? controls.createBadge.call(this, track.language.toUpperCase()) : null, badge: track.language !== 'enabled' ? controls.createBadge.call(this, track.language.toUpperCase()) : null,
track.language.toLowerCase() === this.language, checked: track.language.toLowerCase() === this.language,
); });
}); });
controls.updateSetting.call(this, type, list); controls.updateSetting.call(this, type, list);
@ -927,8 +931,12 @@ const controls = {
// Create items // Create items
this.options.speed.forEach(speed => { this.options.speed.forEach(speed => {
const label = controls.getLabel.call(this, 'speed', speed); controls.createMenuItem.call(this, {
controls.createMenuItem.call(this, speed, list, type, label); value: speed,
list,
type,
title: controls.getLabel.call(this, 'speed', speed),
});
}); });
controls.updateSetting.call(this, type, list); controls.updateSetting.call(this, type, list);