Merge pull request #1027 from friday/quality

Minor code improvements for quality switching
This commit is contained in:
Sam Potts
2018-06-12 11:13:34 +10:00
committed by GitHub
4 changed files with 55 additions and 133 deletions

View File

@ -669,36 +669,31 @@ class Plyr {
* @param {number} input - Quality level
*/
set quality(input) {
let quality = null;
const config = this.config.quality;
const options = this.options.quality;
if (!utils.is.empty(input)) {
quality = Number(input);
}
if (!utils.is.number(quality)) {
quality = this.storage.get('quality');
}
if (!utils.is.number(quality)) {
quality = this.config.quality.selected;
}
if (!utils.is.number(quality)) {
quality = this.config.quality.default;
}
if (!this.options.quality.length) {
if (!options.length) {
return;
}
if (!this.options.quality.includes(quality)) {
const closest = utils.closest(this.options.quality, quality);
let quality = ([
!utils.is.empty(input) && Number(input),
this.storage.get('quality'),
config.selected,
config.default,
]).find(utils.is.number);
if (!options.includes(quality)) {
const closest = utils.closest(options, quality);
this.debug.warn(`Unsupported quality option: ${quality}, using ${closest} instead`);
quality = closest;
}
// Trigger request event
utils.dispatchEvent.call(this, this.media, 'qualityrequested', false, { quality });
// Update config
this.config.quality.selected = quality;
config.selected = quality;
// Set quality
this.media.quality = quality;