Reverted menu change
This commit is contained in:
parent
91a4b86860
commit
00bbce08fb
@ -1,3 +1,7 @@
|
|||||||
|
# v3.3.3
|
||||||
|
|
||||||
|
* Reverted change to show home tab on option select due to usability regression
|
||||||
|
|
||||||
# v3.3.2
|
# v3.3.2
|
||||||
|
|
||||||
* Fix for ads running in audio
|
* Fix for ads running in audio
|
||||||
|
9
dist/plyr.js
vendored
9
dist/plyr.js
vendored
@ -4734,27 +4734,18 @@ var Listeners = function () {
|
|||||||
on(this.player.elements.settings.form, 'click', function (event) {
|
on(this.player.elements.settings.form, 'click', function (event) {
|
||||||
event.stopPropagation();
|
event.stopPropagation();
|
||||||
|
|
||||||
// Go back to home tab on click
|
|
||||||
var showHomeTab = function showHomeTab() {
|
|
||||||
var id = 'plyr-settings-' + _this4.player.id + '-home';
|
|
||||||
controls.showTab.call(_this4.player, id);
|
|
||||||
};
|
|
||||||
|
|
||||||
// Settings menu items - use event delegation as items are added/removed
|
// Settings menu items - use event delegation as items are added/removed
|
||||||
if (utils.matches(event.target, _this4.player.config.selectors.inputs.language)) {
|
if (utils.matches(event.target, _this4.player.config.selectors.inputs.language)) {
|
||||||
proxy(event, function () {
|
proxy(event, function () {
|
||||||
_this4.player.language = event.target.value;
|
_this4.player.language = event.target.value;
|
||||||
showHomeTab();
|
|
||||||
}, 'language');
|
}, 'language');
|
||||||
} else if (utils.matches(event.target, _this4.player.config.selectors.inputs.quality)) {
|
} else if (utils.matches(event.target, _this4.player.config.selectors.inputs.quality)) {
|
||||||
proxy(event, function () {
|
proxy(event, function () {
|
||||||
_this4.player.quality = event.target.value;
|
_this4.player.quality = event.target.value;
|
||||||
showHomeTab();
|
|
||||||
}, 'quality');
|
}, 'quality');
|
||||||
} else if (utils.matches(event.target, _this4.player.config.selectors.inputs.speed)) {
|
} else if (utils.matches(event.target, _this4.player.config.selectors.inputs.speed)) {
|
||||||
proxy(event, function () {
|
proxy(event, function () {
|
||||||
_this4.player.speed = parseFloat(event.target.value);
|
_this4.player.speed = parseFloat(event.target.value);
|
||||||
showHomeTab();
|
|
||||||
}, 'speed');
|
}, 'speed');
|
||||||
} else {
|
} else {
|
||||||
var tab = event.target;
|
var tab = event.target;
|
||||||
|
2
dist/plyr.js.map
vendored
2
dist/plyr.js.map
vendored
File diff suppressed because one or more lines are too long
2
dist/plyr.min.js
vendored
2
dist/plyr.min.js
vendored
File diff suppressed because one or more lines are too long
2
dist/plyr.min.js.map
vendored
2
dist/plyr.min.js.map
vendored
File diff suppressed because one or more lines are too long
2
dist/plyr.polyfilled.js
vendored
2
dist/plyr.polyfilled.js
vendored
@ -6893,6 +6893,8 @@ var ui = {
|
|||||||
// Set ARIA state
|
// Set ARIA state
|
||||||
utils.toggleState(this.elements.buttons.play, this.playing);
|
utils.toggleState(this.elements.buttons.play, this.playing);
|
||||||
|
|
||||||
|
console.warn(this.playing);
|
||||||
|
|
||||||
// Toggle controls
|
// Toggle controls
|
||||||
this.toggleControls(!this.playing);
|
this.toggleControls(!this.playing);
|
||||||
},
|
},
|
||||||
|
2
dist/plyr.polyfilled.js.map
vendored
2
dist/plyr.polyfilled.js.map
vendored
File diff suppressed because one or more lines are too long
2
dist/plyr.polyfilled.min.js
vendored
2
dist/plyr.polyfilled.min.js
vendored
File diff suppressed because one or more lines are too long
2
dist/plyr.polyfilled.min.js.map
vendored
2
dist/plyr.polyfilled.min.js.map
vendored
File diff suppressed because one or more lines are too long
@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "plyr",
|
"name": "plyr",
|
||||||
"version": "3.3.2",
|
"version": "3.3.3",
|
||||||
"description": "A simple, accessible and customizable HTML5, YouTube and Vimeo media player",
|
"description": "A simple, accessible and customizable HTML5, YouTube and Vimeo media player",
|
||||||
"homepage": "https://plyr.io",
|
"homepage": "https://plyr.io",
|
||||||
"main": "./dist/plyr.js",
|
"main": "./dist/plyr.js",
|
||||||
|
@ -489,19 +489,12 @@ class Listeners {
|
|||||||
on(this.player.elements.settings.form, 'click', event => {
|
on(this.player.elements.settings.form, 'click', event => {
|
||||||
event.stopPropagation();
|
event.stopPropagation();
|
||||||
|
|
||||||
// Go back to home tab on click
|
|
||||||
const showHomeTab = () => {
|
|
||||||
const id = `plyr-settings-${this.player.id}-home`;
|
|
||||||
controls.showTab.call(this.player, id);
|
|
||||||
};
|
|
||||||
|
|
||||||
// Settings menu items - use event delegation as items are added/removed
|
// Settings menu items - use event delegation as items are added/removed
|
||||||
if (utils.matches(event.target, this.player.config.selectors.inputs.language)) {
|
if (utils.matches(event.target, this.player.config.selectors.inputs.language)) {
|
||||||
proxy(
|
proxy(
|
||||||
event,
|
event,
|
||||||
() => {
|
() => {
|
||||||
this.player.language = event.target.value;
|
this.player.language = event.target.value;
|
||||||
showHomeTab();
|
|
||||||
},
|
},
|
||||||
'language',
|
'language',
|
||||||
);
|
);
|
||||||
@ -510,7 +503,6 @@ class Listeners {
|
|||||||
event,
|
event,
|
||||||
() => {
|
() => {
|
||||||
this.player.quality = event.target.value;
|
this.player.quality = event.target.value;
|
||||||
showHomeTab();
|
|
||||||
},
|
},
|
||||||
'quality',
|
'quality',
|
||||||
);
|
);
|
||||||
@ -519,7 +511,6 @@ class Listeners {
|
|||||||
event,
|
event,
|
||||||
() => {
|
() => {
|
||||||
this.player.speed = parseFloat(event.target.value);
|
this.player.speed = parseFloat(event.target.value);
|
||||||
showHomeTab();
|
|
||||||
},
|
},
|
||||||
'speed',
|
'speed',
|
||||||
);
|
);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user